[midPoint-git] [Evolveum/connector-scimrest] 0eaafe: Fix misleading JDoc on RestContext.newAuthorizedRe...

[johnstone3]

  Branch: refs/heads/fix/scim-http-error-and-test-auth-2
  Home:   https://github.com/Evolveum/connector-scimrest
  Commit: 0eaafe2137946aa78c31df81ec0722ac54c858a5
      https://github.com/Evolveum/connector-scimrest/commit/0eaafe2137946aa78c31df81ec0722ac54c858a5
  Author: Jan Kamenicky <jan.kamenicky at evolveum.com>
  Date:   2026-05-27 (Wed, 27 May 2026)

  Changed paths:
    M common/src/main/java/com/evolveum/polygon/scimrest/impl/rest/RestContext.java

  Log Message:
  -----------
  Fix misleading JDoc on RestContext.newAuthorizedRequest()

The method only initializes the request with base URI and timeout;
authorization is applied later in executeRequest().


  Commit: 2f21d4f19415725a57492af448b8f6157be5bb56
      https://github.com/Evolveum/connector-scimrest/commit/2f21d4f19415725a57492af448b8f6157be5bb56
  Author: Jan Kamenicky <jan.kamenicky at evolveum.com>
  Date:   2026-05-27 (Wed, 27 May 2026)

  Changed paths:
    M common/src/main/java/com/evolveum/polygon/scimrest/groovy/AbstractGroovyRestConnector.java
    M common/src/main/java/com/evolveum/polygon/scimrest/impl/scim/ScimContext.java
    A common/src/main/java/com/evolveum/polygon/scimrest/impl/scim/ScimHttpErrorFilter.java
    M common/src/test/java/com/evolveum/polygon/scimrest/exception/ScimExceptionSimulationTest.java
    M common/src/test/java/com/evolveum/polygon/scimrest/exception/auth/basic/BasicAuthTests.java
    M common/src/test/java/com/evolveum/polygon/scimrest/exception/auth/basic/ScimHttpBasicTests.java
    M common/src/test/java/com/evolveum/polygon/scimrest/exception/auth/bearertoken/ScimBearerTokenAuthTests.java
    M common/src/test/java/com/evolveum/polygon/scimrest/exception/auth/oauth2clientcredentials/ScimOAuth2ClientCredentialsTests.java

  Log Message:
  -----------
  Fix SCIM connector: send auth headers to REST test endpoint and handle HTTP errors cleanly

ScimHttpErrorFilter intercepts 4xx/5xx responses before the SCIM2
library attempts JSON-B deserialization of ErrorResponse, avoiding
JsonbException in the cause chain.

ScimContext exposes the Jersey HTTP client (httpClient()); AbstractGroovyRestConnector.test()
uses this client when SCIM is active so the JerseyRequestCustomizerFilter
(which holds all registered auth customizers) applies to the test
endpoint request — fixing Bearer, Basic, and OAuth2 auth not being sent.

Tests added for each auth type verifying auth headers reach the test endpoint
in both REST (BasicAuthTests) and SCIM (ScimBearerTokenAuthTests,
ScimHttpBasicTests, ScimOAuth2ClientCredentialsTests) files.


  Commit: f87457e5682051149727af7dc5d50c75ebb71249
      https://github.com/Evolveum/connector-scimrest/commit/f87457e5682051149727af7dc5d50c75ebb71249
  Author: Jan Kamenicky <jan.kamenicky at evolveum.com>
  Date:   2026-05-27 (Wed, 27 May 2026)

  Changed paths:
    M common/src/main/java/com/evolveum/polygon/scimrest/impl/scim/ScimContext.java

  Log Message:
  -----------
  ScimContext: fix NPE on null schemaExtensions, fix relativeEndpoint edge cases

- guard against null schemaExtensions returned by SCIM server
- treat null basePath as empty string instead of throwing
- fix missing space in 'not under basePath' error message
- minor JDoc and whitespace cleanup


  Commit: 019c19cb05b8712d4fb1865c522885e861be8d20
      https://github.com/Evolveum/connector-scimrest/commit/019c19cb05b8712d4fb1865c522885e861be8d20
  Author: Jan Kamenicky <jan.kamenicky at evolveum.com>
  Date:   2026-05-27 (Wed, 27 May 2026)

  Changed paths:
    M common/src/main/java/com/evolveum/polygon/scimrest/config/ScimClientConfiguration.java
    M common/src/main/java/com/evolveum/polygon/scimrest/groovy/AuthorizationCustomizationBuilderImpl.java
    M common/src/main/java/com/evolveum/polygon/scimrest/groovy/api/AuthenticationCustomizationBuilder.java
    M common/src/test/java/com/evolveum/polygon/scimrest/exception/auth/basic/ScimHttpBasicTests.java
    M common/src/test/java/com/evolveum/polygon/scimrest/exception/auth/preference/ScimPreferenceTests.java

  Log Message:
  -----------
  Rename HttpBasic → BasicAuthorization / httpBasic → basic in SCIM auth DSL

Rename the inner interface and DSL method to better reflect that Basic auth
is not specific to HTTP but a general auth scheme name. Also removes
@ConfigurationProperty annotations from the ScimClientConfiguration interface
(they belong in the implementing class, not the interface).


  Commit: be02285e4b3033f8b0fc9c6ff5fa055c2d55697d
      https://github.com/Evolveum/connector-scimrest/commit/be02285e4b3033f8b0fc9c6ff5fa055c2d55697d
  Author: Jan Kamenicky <jan.kamenicky at evolveum.com>
  Date:   2026-05-27 (Wed, 27 May 2026)

  Changed paths:
    M common/src/main/java/com/evolveum/polygon/scimrest/groovy/impl/ReadOnlyConfiguration.java

  Log Message:
  -----------
  ReadOnlyConfiguration: add missing SCIM auth interfaces; move @ConfigurationProperty here

Add BasicAuthorization, ApiKeyAuthorization, OAuth2ClientCredentials and
OAuth2JwtBearer SCIM interfaces with their fields and getters. Move all
@ConfigurationProperty annotations (including allowedValues for JWT algorithm)
from the interface to this concrete implementation class where they belong.


  Commit: 22e713fd05909a3cac437ee2e8be1e39d59e252a
      https://github.com/Evolveum/connector-scimrest/commit/22e713fd05909a3cac437ee2e8be1e39d59e252a
  Author: Jan Kamenicky <jan.kamenicky at evolveum.com>
  Date:   2026-05-27 (Wed, 27 May 2026)

  Changed paths:
    M common/src/main/java/com/evolveum/polygon/scimrest/groovy/AbstractGroovyRestConnector.java

  Log Message:
  -----------
  Fix test connection URL and null guard for REST context

Use scimBaseUrl instead of baseAddress when building the test endpoint URL
for SCIM-enabled connectors. Guard context.rest() null checks so connectors
that only configure SCIM (no REST context) do not throw NPE during test.


Compare: https://github.com/Evolveum/connector-scimrest/compare/20254dd6bb11...22e713fd0590

To unsubscribe from these emails, change your notification settings at https://github.com/Evolveum/connector-scimrest/settings/notifications