[midPoint-git] [Evolveum/midpoint] 1e822f: Smart Integration: Skip mapping suggestions for al...

Michal Zelenčík noreply at github.com
Thu Jan 29 10:37:30 CET 2026


  Branch: refs/heads/feature/mapping-deduplication
  Home:   https://github.com/Evolveum/midpoint
  Commit: 1e822f5a5d029df120dfe11ce5b60d6820a6c1f8
      https://github.com/Evolveum/midpoint/commit/1e822f5a5d029df120dfe11ce5b60d6820a6c1f8
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2026-01-29 (Thu, 29 Jan 2026)

  Changed paths:
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/AttributeMappingCandidateSet.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java

  Log Message:
  -----------
  Smart Integration: Skip mapping suggestions for already-mapped attributes

AttributeMappingCandidateSet now accepts existing mapping paths and
filters out candidates targeting paths that already have mappings.

MappingsSuggestionOperation collects target paths from existing
inbound/outbound mappings on the resource and passes them to the
candidate set for deduplication.

Signed-off-by: Michal Zelencik <michal.zelencik at evolveum.com>


  Commit: fb879e449697dd57e2cf43556a246ab4bcbfce8b
      https://github.com/Evolveum/midpoint/commit/fb879e449697dd57e2cf43556a246ab4bcbfce8b
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2026-01-29 (Thu, 29 Jan 2026)

  Changed paths:
    M infra/schema/src/main/resources/xml/ns/public/common/common-smart-integration-3.xsd
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/AttributeMappingCandidateSet.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingSuggestionOperationFactory.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/SmartIntegrationServiceImpl.java
    M model/smart-impl/src/test/java/com/evolveum/midpoint/smart/impl/TestMappingsSuggestionOperation.java
    M model/smart-impl/src/test/java/com/evolveum/midpoint/smart/impl/TestSystemMappingsSuggestion.java

  Log Message:
  -----------
  Smart Integration: exclude accepted mapping suggestions from new suggestions

When a user accepts a mapping suggestion but hasn't saved it yet, the
suggestion was being re-proposed because it wasn't in the resource yet.

This change adds support for passing accepted suggestions via
interactionMetadata, allowing the backend to filter them out:

- Add acceptedAttributeMappingsSuggestion to MappingsSuggestionInteractionMetadataType XSD
- Update MappingsSuggestionOperation to collect and process accepted suggestions
- Extend AttributeMappingCandidateSet to filter out accepted suggestion paths
- Pass interactionMetadata through the factory and service layers

GUI changes are required to populate acceptedAttributeMappingsSuggestion
when calling suggestMappings.

Signed-off-by: Michal Zelencik <michal.zelencik at evolveum.com>


Compare: https://github.com/Evolveum/midpoint/compare/1e822f5a5d02%5E...fb879e449697

To unsubscribe from these emails, change your notification settings at https://github.com/Evolveum/midpoint/settings/notifications


More information about the midPoint-svn mailing list