[midPoint-git] [Evolveum/midpoint] 8ad3a1: Smart Integration: Refactor system mapping suggest...

[Michal Zelenčík]

  Branch: refs/heads/feature/system-mappings
  Home:   https://github.com/Evolveum/midpoint
  Commit: 8ad3a1308e2b38b1d4027d258d0785311152442f
      https://github.com/Evolveum/midpoint/commit/8ad3a1308e2b38b1d4027d258d0785311152442f
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2026-01-21 (Wed, 21 Jan 2026)

  Changed paths:
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/SchemaMatchService.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/SchemaMatchingOperation.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/SystemMappingSuggestion.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/WellKnownSchemaProvider.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/ad/UserActiveDirectoryMappingProvider.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/ldap/InetOrgPersonLdapMappingProvider.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/scim/UserScimMappingProvider.java

  Log Message:
  -----------
  Smart Integration: Refactor system mapping suggestion creation and processing

- Move factory methods from WellKnownSchemaProvider to SystemMappingSuggestion record
  - Add createAsIsSuggestion() for simple mappings without scripts
  - Add createScriptSuggestion() for script-based mappings
  - Remove old createSystemMappingSuggestion() static method

- Refactor MappingsSuggestionOperation.addSystemMappings()
  - Rename to collectSystemMappings() and return List instead of void
  - Extract single mapping processing into assessAndBuildSystemMapping()
  - Remove isSystemProvided parameter from suggestMapping() (derive from matchPair)

Signed-off-by: Michal Zelencik <michal.zelencik at evolveum.com>


  Commit: d9fad352e88142597e1cf3fcf22f01489bee5d28
      https://github.com/Evolveum/midpoint/commit/d9fad352e88142597e1cf3fcf22f01489bee5d28
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2026-01-21 (Wed, 21 Jan 2026)

  Changed paths:
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/AttributeMappingCandidate.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java

  Log Message:
  -----------
  Smart Integration: Introduce deduplication of mapping suggestions

Add AttributeMappingCandidate wrapper to enable duplicate detection and
quality-based selection. When duplicate mappings are found (same shadow
attribute and focus property), keep the one with higher quality. If
quality is equal, prefer system-provided over AI-generated mappings.

This prevents duplicate mapping suggestions in the final output while
ensuring the best quality mapping is retained.

Signed-off-by: Michal Zelencik <michal.zelencik at evolveum.com>


Compare: https://github.com/Evolveum/midpoint/compare/8ab57f1bb684...d9fad352e881

To unsubscribe from these emails, change your notification settings at https://github.com/Evolveum/midpoint/settings/notifications