[midPoint-git] [Evolveum/midpoint] aa156c: Smart Integration: Refactor well-known schema mapp...

[Michal Zelenčík]

  Branch: refs/heads/feature/system-mappings
  Home:   https://github.com/Evolveum/midpoint
  Commit: aa156c5d9956d2d1acbdafe6a0a681153d5d00f4
      https://github.com/Evolveum/midpoint/commit/aa156c5d9956d2d1acbdafe6a0a681153d5d00f4
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2026-01-19 (Mon, 19 Jan 2026)

  Changed paths:
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/SystemMappingSuggestion.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/WellKnownSchemaProvider.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/ad/UserActiveDirectoryMappingProvider.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/ldap/InetOrgPersonLdapMappingProvider.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/scim/UserScimMappingProvider.java
    M model/smart-impl/src/test/java/com/evolveum/midpoint/smart/impl/DummyScenario.java
    M model/smart-impl/src/test/java/com/evolveum/midpoint/smart/impl/TestMappingsSuggestionOperation.java

  Log Message:
  -----------
  Smart Integration: Refactor well-known schema mappings for quality assessment

- Refactored SystemMappingSuggestion to hold raw mapping data (paths, expression)
  instead of complete AttributeMappingsSuggestionType structure
- Updated WellKnownSchemaProvider interface to return SystemMappingSuggestion objects
- Centralized mapping construction in MappingsSuggestionOperation.buildAttributeMappingSuggestion
- This enables quality assessment for system-provided mappings using the same
  logic as AI-suggested mappings

Bug Fix:
- Fixed shadow attribute paths to include ShadowType.F_ATTRIBUTES prefix
  (e.g., "attributes/cn" instead of "cn") so ValuesPairSample can correctly
  extract shadow values for quality assessment

Implementation Updates:
- Updated all WellKnownSchemaProvider implementations (LDAP, AD, SCIM) to use
  simplified createSystemMappingSuggestion helper method
- Removed deprecated createInboundMapping/createOutboundMapping helper methods
- MappingsSuggestionOperation.addSystemMappings now assesses quality for each
  system mapping using the same flow as AI mappings

Signed-off-by: Michal Zelencik <michal.zelencik at evolveum.com>


  Commit: b907576a11212dfdfac5aec89a8b9f35486209ec
      https://github.com/Evolveum/midpoint/commit/b907576a11212dfdfac5aec89a8b9f35486209ec
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2026-01-20 (Tue, 20 Jan 2026)

  Changed paths:
    M infra/schema/src/main/resources/xml/ns/public/common/common-smart-integration-3.xsd
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/SchemaMatchService.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/SchemaMatchingOperation.java

  Log Message:
  -----------
  Smart Integration: Mark well-known schema mappings as system-provided

Add isSystemProvided boolean field to schema match types to distinguish
mappings from well-known schema detection from AI-generated mappings.

- Add isSystemProvided field to SiAttributeMatchSuggestionType and
  SchemaMatchOneResultType in XSD schema
- Set isSystemProvided=true in SchemaMatchingOperation when matches come
  from well-known schema providers
- Use flag in MappingsSuggestionOperation to mark final mappings:
  * System-provided if from well-known schema and no AI involvement
  * AI-provided if LLM was used for mapping generation

Signed-off-by: Michal Zelencik <michal.zelencik at evolveum.com>


Compare: https://github.com/Evolveum/midpoint/compare/aa156c5d9956%5E...b907576a1121

To unsubscribe from these emails, change your notification settings at https://github.com/Evolveum/midpoint/settings/notifications