[midPoint-git] [Evolveum/midpoint] 28a9fd: Objet type error loop review:

Michal Zelenčík noreply at github.com
Thu Nov 6 15:11:16 CET 2025


  Branch: refs/heads/improvement/object-type-retry-loop
  Home:   https://github.com/Evolveum/midpoint
  Commit: 28a9fdf5f26daa82ddc69f3b24e18f47a28d378d
      https://github.com/Evolveum/midpoint/commit/28a9fdf5f26daa82ddc69f3b24e18f47a28d378d
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/ObjectTypesSuggestionOperation.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/ObjectTypesSuggestionOperationFactory.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/SmartIntegrationBeans.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/SmartIntegrationServiceImpl.java
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/scoring/ObjectTypeFiltersValidator.java
    R model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/scoring/ObjectTypesQualityAssessor.java

  Log Message:
  -----------
  Objet type error loop review:
- Rename ObjectTypeQualityAssessor to ObjectTypeFiltersValidator,
  because it only tests filter runnability.
- Switch parameter order: put parentResult as last parameter
- Fix exception handling
- Move provisioning service from SmartIntegrationBeans to FiltersValidator
- Small fixes


  Commit: ad59ba419cb58e3203250549c2a347ade3e39f15
      https://github.com/Evolveum/midpoint/commit/ad59ba419cb58e3203250549c2a347ade3e39f15
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2025-11-06 (Thu, 06 Nov 2025)

  Changed paths:
    M infra/schema/src/main/resources/xml/ns/public/common/common-smart-integration-3.xsd
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/ObjectTypesSuggestionOperation.java

  Log Message:
  -----------
  Use structured validation feedback for object type suggestion retries

- Replace concatenated logs with structured per-suggestion feedback
- Build feedback entries with human-readable validation messages tied to each suggestion
- On retry, include the feedback
- Redesign exception to carry structured feedback
- Minor cleanup of comments and imports


Compare: https://github.com/Evolveum/midpoint/compare/e79228aa334b...ad59ba419cb5

To unsubscribe from these emails, change your notification settings at https://github.com/Evolveum/midpoint/settings/notifications


More information about the midPoint-svn mailing list