[midPoint-git] [Evolveum/midpoint] 0d01a1: Smart Integration: Skip low-quality mapping sugges...

Michal Zelenčík noreply at github.com
Thu Dec 11 13:33:38 CET 2025


  Branch: refs/heads/midpilot
  Home:   https://github.com/Evolveum/midpoint
  Commit: 0d01a18a85b8175c02a5e96a50b6c19c8784f6f6
      https://github.com/Evolveum/midpoint/commit/0d01a18a85b8175c02a5e96a50b6c19c8784f6f6
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2025-12-11 (Thu, 11 Dec 2025)

  Changed paths:
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/LowQualityMappingException.java
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/MissingSourceDataException.java
    M model/smart-impl/src/test/java/com/evolveum/midpoint/smart/impl/TestMappingsSuggestionOperation.java

  Log Message:
  -----------
  Smart Integration: Skip low-quality mapping suggestions using threshold-based filtering

Introduce quality thresholds to improve mapping suggestion reliability:
- Add 5% threshold for missing data detection in isSourceDataMissing/isTargetDataMissing
- Add 10% minimum quality threshold for suggested mappings
- Implement LowQualityMappingException to handle mappings below threshold
- Record low-quality mappings as SKIP instead of FAILURE

When data is too sparse (<5% of pairs have values), skip LLM call and use
asIs mapping with null quality. When assessed quality falls below 10%,
throw exception and skip the mapping entirely rather than returning
potentially incorrect suggestions.

**Implements:** MID-10804

Signed-off-by: Michal Zelencik <michal.zelencik at evolveum.com>


  Commit: 6b9402d2c3f10f234e35ae5d19c3445a53a66b60
      https://github.com/Evolveum/midpoint/commit/6b9402d2c3f10f234e35ae5d19c3445a53a66b60
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2025-12-11 (Thu, 11 Dec 2025)

  Changed paths:
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/MappingDirection.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/ValuesPair.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/ValuesPairSample.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/scoring/MappingsQualityAssessor.java
    M model/smart-impl/src/test/java/com/evolveum/midpoint/smart/impl/TestMappingsSuggestionOperation.java

  Log Message:
  -----------
  Smart Integration: Separate value pair analysis logic

Move direction-aware data analysis methods from MappingsSuggestionOperation
into ValuesPair and ValuesPairSample classes where they semantically belong.

- Introduce MappingDirection enum (INBOUND/OUTBOUND) to replace direction booleans
- Move isSourceDataMissing() and isTargetDataMissing() to ValuesPairSample
- Move asIs mapping detection to ValuesPairSample.allSourceValuesMatchTarget()
- Add direction-aware getSourceValues/getTargetValues methods to ValuesPair
- Update MappingsQualityAssessor to use direction from sample object
- Simplify all call sites to use new encapsulated methods
- Refactor naming

**Implements:** MID-10804

Signed-off-by: Michal Zelencik <michal.zelencik at evolveum.com>


  Commit: 57ded3a146bd87b3feadf849b3a3b9bfc52193bf
      https://github.com/Evolveum/midpoint/commit/57ded3a146bd87b3feadf849b3a3b9bfc52193bf
  Author: Michal Zelencik <michal.zelencik at evolveum.com>
  Date:   2025-12-11 (Thu, 11 Dec 2025)

  Changed paths:
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/MappingsSuggestionOperation.java
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/LowQualityMappingException.java
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/MappingDirection.java
    A model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/MissingSourceDataException.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/ValuesPair.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/ValuesPairSample.java
    M model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/scoring/MappingsQualityAssessor.java
    M model/smart-impl/src/test/java/com/evolveum/midpoint/smart/impl/TestMappingsSuggestionOperation.java

  Log Message:
  -----------
  Merge branch 'feature/utilize-mapping-statistics-review-2' into midpilot


Compare: https://github.com/Evolveum/midpoint/compare/e9f5739e1e14...57ded3a146bd

To unsubscribe from these emails, change your notification settings at https://github.com/Evolveum/midpoint/settings/notifications


More information about the midPoint-svn mailing list