[midPoint-git] [Evolveum/midpoint] c1c939: Fix non-leaf activities with explicit identifiers

mederly noreply at github.com
Thu Apr 21 11:26:27 CEST 2022


  Branch: refs/heads/support-4.4
  Home:   https://github.com/Evolveum/midpoint
  Commit: c1c9396e5dbc9cfbe12b3ee8f7cef40cf22ee7c1
      https://github.com/Evolveum/midpoint/commit/c1c9396e5dbc9cfbe12b3ee8f7cef40cf22ee7c1
  Author: Pavol Mederly <mederly at evolveum.com>
  Date:   2022-04-21 (Thu, 21 Apr 2022)

  Changed paths:
    M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/cleanup/CleanupActivityHandler.java
    M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/ReconciliationActivityHandler.java
    M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/scanner/FocusValidityScanActivityHandler.java
    M model/model-intest/src/test/resources/tasks/recon/task-reconciliation.xml
    M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/DistributedReportExportActivityHandler.java
    M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/Activity.java
    M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/EmbeddedActivity.java
    M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/definition/ActivityDefinition.java
    M repo/repo-common/src/test/java/com/evolveum/midpoint/repo/common/tasks/handlers/composite/CompositeMockActivityHandler.java

  Log Message:
  -----------
  Fix non-leaf activities with explicit identifiers

When a non-leaf activity (e.g. a reconciliation) was defined with
an explicit identifier, all its children obtained the identifier,
causing troubles. This is now fixed by stopping cloning the
identifier value. (Thanks to Marc Fueller for the analysis.)

This resolves MID-7894.

Other changes:
- Added a check for conflicting identifiers in child activities.
- Slightly improved thread safety of Activity#childrenMap.




More information about the midPoint-svn mailing list