[midPoint-git] [Evolveum/midpoint] 5395a1: Kill separate ActivityExecutionSpecifics hierarchy
mederly
noreply at github.com
Fri Sep 10 21:04:33 CEST 2021
Branch: refs/heads/tmp/killing-specifics
Home: https://github.com/Evolveum/midpoint
Commit: 5395a18032650409c1f495778cd1ad01fc33d29c
https://github.com/Evolveum/midpoint/commit/5395a18032650409c1f495778cd1ad01fc33d29c
Author: Pavol Mederly <mederly at evolveum.com>
Date: 2021-09-10 (Fri, 10 Sep 2021)
Changed paths:
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/cleanup/ShadowRefreshActivityHandler.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/integrity/objects/ObjectIntegrityCheckActivityHandler.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/integrity/shadows/ShadowIntegrityCheckActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/integrity/shadows/ShadowIntegrityCheckActivityExecutionSpecifics.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/integrity/shadows/ShadowIntegrityCheckActivityHandler.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/integrity/shadows/ShadowIntegrityCheckItemProcessor.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/scripting/IterativeScriptingActivityHandler.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/SyncItemProcessingRequest.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/async/AsyncUpdateActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/async/AsyncUpdateActivityExecutionSpecifics.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/async/AsyncUpdateActivityHandler.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/imp/ImportActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/imp/ImportActivityExecutionSpecifics.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/imp/ImportActivityHandler.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/OperationCompletionActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/OperationCompletionActivityExecutionSpecifics.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/PartialReconciliationActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/PartialReconciliationActivityExecutionSpecifics.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/ReconciliationActivityExecution.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/ReconciliationActivityHandler.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/ReconciliationResult.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/RemainingShadowsActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/RemainingShadowsActivityExecutionSpecifics.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/ResourceObjectsReconciliationActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/recon/ResourceObjectsReconciliationActivityExecutionSpecifics.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/sync/LiveSyncActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/sync/LiveSyncActivityExecutionSpecifics.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/sync/tasks/sync/LiveSyncActivityHandler.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/AdvancedActivityExecutionSupportImpl.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/ChangeExecutionActivityHandler.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/ModelSearchBasedActivityExecution.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/RecomputationActivityHandler.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/ReindexActivityHandler.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/ShadowCleanupActivityHandler.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/ShadowFetchingPreprocessor.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/cluster/AutoScalingActivityExecution.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/cluster/AutoScalingActivityHandler.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/cluster/AutoScalingExecutionSpecifics.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/cluster/ReconciliationLatch.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/scanner/FocusValidityScanActivityHandler.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/scanner/FocusValidityScanPartialExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/scanner/FocusValidityScanPartialExecutionSpecifics.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/scanner/ScanActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/scanner/ScanActivityExecutionSpecifics.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/simple/SimpleActivityHandler.java
A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/trigger/TriggerScanActivityExecution.java
R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/trigger/TriggerScanActivityExecutionSpecifics.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/trigger/TriggerScanActivityHandler.java
M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/trigger/TriggerScanItemProcessor.java
M model/model-intest/src/test/resources/logback-test.xml
M model/model-intest/src/test/resources/tasks/livesync/resource-dummy-multi-changes.xml
A model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ClassicCollectionReportExportActivityExecution.java
R model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ClassicCollectionReportExportActivityExecutionSpecifics.java
A model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ClassicDashboardReportExportActivityExecution.java
R model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ClassicDashboardReportExportActivityExecutionSpecifics.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ClassicReportExportActivityHandler.java
A model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ClassicReportImportActivityExecution.java
R model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ClassicReportImportActivityExecutionSpecifics.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ClassicReportImportActivityHandler.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/DistributedReportExportActivityHandler.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ExportDashboardReportLineProcessingRequest.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/InputReportLineProcessingRequest.java
A model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ReportDataAggregationActivityExecution.java
R model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ReportDataAggregationExecutionSpecifics.java
A model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ReportDataCreationActivityExecution.java
R model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/activity/ReportDataCreationExecutionSpecifics.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/controller/CollectionDistributedExportController.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/controller/CollectionExportController.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/controller/DashboardExportController.java
M model/report-impl/src/main/java/com/evolveum/midpoint/report/impl/controller/DashboardWidgetExportController.java
A provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/shadows/task/MultiPropagationActivityExecution.java
R provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/shadows/task/MultiPropagationActivityExecutionSpecifics.java
M provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/shadows/task/MultiPropagationActivityHandler.java
A provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/shadows/task/PropagationActivityExecution.java
R provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/shadows/task/PropagationActivityExecutionSpecifics.java
M provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/shadows/task/PropagationActivityHandler.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/execution/AbstractActivityExecution.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/handlers/NoOpActivityHandler.java
A repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/AdvancedActivityExecutionSupport.java
R repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/BaseActivityExecutionSpecificsImpl.java
R repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/BasePlainIterativeExecutionSpecificsImpl.java
R repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/BaseSearchBasedExecutionSpecificsImpl.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/CommonTaskBeans.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/ContainerableProcessingRequest.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/GenericProcessingRequest.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/ItemProcessingConditionEvaluator.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/ItemProcessingGatekeeper.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/ItemProcessingMonitor.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/ItemProcessingRequest.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/IterativeActivityExecution.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/IterativeActivityExecutionSpecifics.java
A repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/NoOpAdvancedActivityExecutionSupport.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/ObjectProcessingRequest.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/PlainIterativeActivityExecution.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/PlainIterativeActivityExecutionSpecifics.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/SearchBasedActivityExecution.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/SearchBasedActivityExecutionSpecifics.java
M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/task/StatisticsLogger.java
A repo/repo-common/src/test/java/com/evolveum/midpoint/repo/common/tasks/handlers/iterative/IterativeMockActivityExecution.java
R repo/repo-common/src/test/java/com/evolveum/midpoint/repo/common/tasks/handlers/iterative/IterativeMockActivityExecutionSpecifics.java
M repo/repo-common/src/test/java/com/evolveum/midpoint/repo/common/tasks/handlers/iterative/IterativeMockActivityHandler.java
A repo/repo-common/src/test/java/com/evolveum/midpoint/repo/common/tasks/handlers/search/SearchBasedMockActivityExecution.java
R repo/repo-common/src/test/java/com/evolveum/midpoint/repo/common/tasks/handlers/search/SearchBasedMockActivityExecutionSpecifics.java
M repo/repo-common/src/test/java/com/evolveum/midpoint/repo/common/tasks/handlers/search/SearchIterativeMockActivityHandler.java
M testing/story/src/test/resources/logback-test.xml
Log Message:
-----------
Kill separate ActivityExecutionSpecifics hierarchy
The idea of separation of generic activity framework code
from specific implementations using object composition
(via implementing xxxActivityExecutionSpecifics interfaces
in "small" classes) - in 63812e8ce822f8dd03de746fc4b36906542c8f82 -
was most probably flawed.
So this commit returns to the original design of subclassing
xxxActivityExecution classes, with some differences:
1. The xxxActivityExecutionSpecifics interfaces remain there. They
indicate what methods should implementers provide to get the full
functionality.
2. The implementors are not allowed to override internal methods
in xxxActivityExecution classes. They are now either private or final.
(This should simplify the maintenance of the solution.)
3. ModelSearchBasedActivityExecution was removed. The required model-
level functionality is now provided by AdvancedActivityExecutionSupport
and its implementation residing in model-impl.
More information about the midPoint-svn
mailing list