[midPoint-git] [Evolveum/midpoint] 8620f6: Migrate DeleteTaskHandler to activity

mederly noreply at github.com
Fri Nov 12 20:42:57 CET 2021


  Branch: refs/heads/master
  Home:   https://github.com/Evolveum/midpoint
  Commit: 8620f6f157cfcafc41f467b56860a985e14a430a
      https://github.com/Evolveum/midpoint/commit/8620f6f157cfcafc41f467b56860a985e14a430a
  Author: Pavol Mederly <mederly at evolveum.com>
  Date:   2021-11-12 (Fri, 12 Nov 2021)

  Changed paths:
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/result/OperationResult.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/util/ObjectTypeUtil.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/util/ShadowUtil.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/util/task/ActivityBasedTaskInformation.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/util/task/work/WorkDefinitionUtil.java
    M infra/schema/src/main/resources/xml/ns/public/common/common-tasks-3.xsd
    M model/certification-impl/src/main/java/com/evolveum/midpoint/certification/impl/AccessCertificationCampaignCreationTaskHandler.java
    M model/certification-impl/src/main/java/com/evolveum/midpoint/certification/impl/AccessCertificationClosingTaskHandler.java
    M model/certification-impl/src/main/java/com/evolveum/midpoint/certification/impl/AccessCertificationRemediationTaskHandler.java
    M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/controller/ExecuteDeltasTaskHandler.java
    A model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/DeletionActivityHandler.java
    M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/RecomputationActivityHandler.java
    R model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/old/DeleteTaskHandler.java
    M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/tasks/simple/SimpleActivityHandler.java
    M model/model-intest/src/test/java/com/evolveum/midpoint/model/intest/tasks/TestMiscTasks.java
    M model/model-intest/src/test/resources/logback-test.xml
    A model/model-intest/src/test/resources/tasks/misc/task-delete-missing-query-legacy.xml
    A model/model-intest/src/test/resources/tasks/misc/task-delete-missing-type.xml
    A model/model-intest/src/test/resources/tasks/misc/task-delete-selected-users.xml
    M model/notifications-impl/src/main/java/com/evolveum/midpoint/notifications/impl/events/TaskEventImpl.java
    M model/workflow-impl/src/main/java/com/evolveum/midpoint/wf/impl/execution/CaseOperationExecutionTaskHandler.java
    M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/run/AbstractActivityRun.java
    M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/run/ActivityRunException.java
    M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/run/ActivityRunResult.java
    M repo/repo-common/src/main/java/com/evolveum/midpoint/repo/common/activity/run/LocalActivityRun.java
    M repo/repo-test-util/src/main/java/com/evolveum/midpoint/test/asserter/TaskAsserter.java
    M repo/task-api/src/main/java/com/evolveum/midpoint/task/api/TaskRunResult.java
    M repo/task-quartz-impl/src/main/java/com/evolveum/midpoint/task/quartzimpl/TaskQuartzImpl.java
    M repo/task-quartz-impl/src/main/java/com/evolveum/midpoint/task/quartzimpl/handlers/JdbcPingTaskHandler.java
    M repo/task-quartz-impl/src/main/java/com/evolveum/midpoint/task/quartzimpl/run/HandlerExecutor.java
    M repo/task-quartz-impl/src/main/java/com/evolveum/midpoint/task/quartzimpl/run/TaskCycleExecutor.java
    M repo/task-quartz-impl/src/main/java/com/evolveum/midpoint/task/quartzimpl/tasks/TaskRetriever.java
    M testing/longtest/src/test/resources/logback-test.xml

  Log Message:
  -----------
  Migrate DeleteTaskHandler to activity

This commit creates DeletionActivityHandler as a replacement for the
legacy handler code.

It also fixes OperationResult-handling code in tasks/activities:

1. We definitely got rid of TaskRunResult#operationResult property.
So the task handlers can no longer provide their "own" result.
They should use Task#getResult() or create a subresult of it.
Legacy task handlers were adapted to this change.

2. Therefore, TaskRunResult and ActivityRunResult got properties that
keep the exception responsible for the run failure, plus TRR also the
message. These properties (if present) are used to update task's
root operation result.

3. The Task#refresh method no longer updates live operation result
for RunningTask instances. Quite the opposite: it updates in-prism
version of the result from the live one.

Unrelated change:

- Fixed root xsd:element definitions in common-tasks-3.xsd.




More information about the midPoint-svn mailing list