[midPoint-git] [Evolveum/midpoint] d7ecd1: MID-6319: TODOs about unused ItemRestrictionOperat...

virgo47 noreply at github.com
Mon Jul 13 16:15:34 CEST 2020


  Branch: refs/heads/master
  Home:   https://github.com/Evolveum/midpoint
  Commit: d7ecd128d933cf59eaa65db1b895051920d9025d
      https://github.com/Evolveum/midpoint/commit/d7ecd128d933cf59eaa65db1b895051920d9025d
  Author: Richard Richter <richard.richter at evolveum.com>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/query/matcher/Matcher.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/query/restriction/ItemRestrictionOperation.java

  Log Message:
  -----------
  MID-6319: TODOs about unused ItemRestrictionOperation#NULL/NOT_NULL


  Commit: ce5c7b22415a0100658ba941e265b983fc0061bd
      https://github.com/Evolveum/midpoint/commit/ce5c7b22415a0100658ba941e265b983fc0061bd
  Author: Richard Richter <richard.richter at evolveum.com>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/data/audit/RObjectDeltaOperation.java

  Log Message:
  -----------
  RObjectDeltaOperation: removed old commented equals/hashCode


  Commit: c00313f65df39b85cee28c02c57d479a90248147
      https://github.com/Evolveum/midpoint/commit/c00313f65df39b85cee28c02c57d479a90248147
  Author: Richard Richter <richard.richter at evolveum.com>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/NaryLogicalFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/NotFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/ObjectFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/PropertyValueFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/RefFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/SqlPathContext.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/ItemSqlMapper.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/QueryModelMapping.java

  Log Message:
  -----------
  MID-6319: added parameters to SqlPathContext usages


  Commit: 5e95da0cda3e41d70ff1b4aab3e4b7a9882dea21
      https://github.com/Evolveum/midpoint/commit/5e95da0cda3e41d70ff1b4aab3e4b7a9882dea21
  Author: Richard Richter <richard.richter at evolveum.com>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/PropertyValueFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/RefFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/SqlPathContext.java

  Log Message:
  -----------
  MID-6319: mapping.createItemFilterProcessor exposed on SqlPathContext

Not only it makes client code cleaner (instead of getting the mapping
and then calling the method there with the context - from which we got
the mapping on which we call the method! - as parameter) but also
prevents parametrization problems with context.mapping().anotherCall().


  Commit: a825d5f4cde62c1aa24098daeff99edcfea6c9dd
      https://github.com/Evolveum/midpoint/commit/a825d5f4cde62c1aa24098daeff99edcfea6c9dd
  Author: Richard Richter <richard.richter at evolveum.com>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M repo/repo-sql-impl-test/src/test/java/com/evolveum/midpoint/repo/sql/AuditSearchTest.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/NotFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/SqlPathContext.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/EnumOrdinalItemFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/ItemFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/ItemSqlMapper.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/QueryModelMapping.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/RefItemFilterProcessor.java
    A repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/SinglePathItemFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/StringItemFilterProcessor.java
    M repo/repo-sql-impl/src/main/java/com/evolveum/midpoint/repo/sql/pure/mapping/TimestampItemFilterProcessor.java

  Log Message:
  -----------
  MID-6319: added test+fix for NOT(nullable-prop-condition) treatment

Normally SQL does not return NULL for NOT x=y, but in our filter the NOT
has complement semantics and should return NULL values too.
This can be fixed by adding " AND x IS NOT NULL" inside the NOT just
after each condition inside.
Refactoring was required so that item filter processors can ask the
context, whether there is NOT filter above them.
During the refactoring SinglePathItemFilterProcessor emerged.
While currently all IFPs are extending it, PolyStringIFP will not.


Compare: https://github.com/Evolveum/midpoint/compare/bd83f40f5c98...a825d5f4cde6


More information about the midPoint-svn mailing list