[midPoint-git] [Evolveum/midpoint] fc2584: Refactor StringChoiceRenderer

Radovan Semancik radovan.semancik at evolveum.com
Mon Sep 11 10:47:20 CEST 2017


  Branch: refs/heads/master
  Home:   https://github.com/Evolveum/midpoint
  Commit: fc258463edb3af3caec05dd5f9c3cd05c1e05ca1
      https://github.com/Evolveum/midpoint/commit/fc258463edb3af3caec05dd5f9c3cd05c1e05ca1
  Author: Robert Varga <nite at hq.sk>
  Date:   2017-09-09 (Sat, 09 Sep 2017)

  Changed paths:
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/input/StringChoiceRenderer.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/wizard/resource/component/schemahandling/modal/MappingEditorDialog.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/wizard/resource/component/synchronization/SynchronizationReactionEditor.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageAccounts.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/component/LoggingConfigPanel.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/PageCreatedReports.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/server/PageTaskAdd.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/server/PageTasks.java

  Log Message:
  -----------
  Refactor StringChoiceRenderer

This class is used in three distinct cases:
- no prefix at all
- with a prefix
- with a prefix and a split pattern

Refactor each case into a separate subclass and expose them
via static factory methods. This allows for smaller footprint
and more direct execution paths, as well as sharing a single object
for the non-prefixed case.

Users are updated to account for the split and to reuse instances
where possible.

Signed-off-by: Robert Varga <nite at hq.sk>


  Commit: d7d114b1a1418f427e83cc4e2acc8f752d542ca2
      https://github.com/Evolveum/midpoint/commit/d7d114b1a1418f427e83cc4e2acc8f752d542ca2
  Author: Radovan Semancik <radovan.semancik at evolveum.com>
  Date:   2017-09-11 (Mon, 11 Sep 2017)

  Changed paths:
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/input/StringChoiceRenderer.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/wizard/resource/component/schemahandling/modal/MappingEditorDialog.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/wizard/resource/component/synchronization/SynchronizationReactionEditor.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageAccounts.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/component/LoggingConfigPanel.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/PageCreatedReports.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/server/PageTaskAdd.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/server/PageTasks.java

  Log Message:
  -----------
  Merge pull request #48 from rovarga/string-choice-renderer

Refactor StringChoiceRenderer


Compare: https://github.com/Evolveum/midpoint/compare/93dccf851cb9...d7d114b1a141


More information about the midPoint-svn mailing list