[midPoint-git] [Evolveum/midpoint] 3329ec: MID-9153: Sqale: Changed how locking in m_refresh_...

Tony Tkáčik noreply at github.com
Mon Oct 2 12:06:39 CEST 2023


  Branch: refs/heads/master
  Home:   https://github.com/Evolveum/midpoint
  Commit: 3329ec79893abf63d945bdb41d706ce2458fd795
      https://github.com/Evolveum/midpoint/commit/3329ec79893abf63d945bdb41d706ce2458fd795
  Author: Tony Tkáčik <tonydamage at gmail.com>
  Date:   2023-09-29 (Fri, 29 Sep 2023)

  Changed paths:
    M config/sql/native/postgres-upgrade.sql
    M config/sql/native/postgres.sql
    M repo/repo-sqale/src/main/java/com/evolveum/midpoint/repo/sqale/SqaleUtils.java

  Log Message:
  -----------
  MID-9153: Sqale: Changed how locking in m_refresh_org_closuer works

m_refresh_org_closure used double check mechanism with locks which
is common Java pattern:
 - check before locking if refresh is needed,
 - check after locking if refresh is still needed
 - do work

Which does not work correctly with PostgreSQL transaction guaranties
becouse once data are readed in transaction, logic states that
the value will be same for subsequent reads, that means second check
was always same as first.

The change is removing first check outside lock, so checks are doneň
only under lock.


  Commit: a72c04a25a2da58ccae91d56f8f954cfd937030e
      https://github.com/Evolveum/midpoint/commit/a72c04a25a2da58ccae91d56f8f954cfd937030e
  Author: Tony Tkáčik <tonydamage at gmail.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/self/requestAccess/CartSummaryPanel.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/self/requestAccess/PersonOfInterestPanel.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/self/requestAccess/RequestAccess.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/self/requestAccess/RoleCatalogPanel.java
    M gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/impl/page/self/requestAccess/ShoppingCartItem.java
    A gui/admin-gui/src/test/java/com/evolveum/midpoint/web/RequestAccessTest.java
    M infra/common/src/test/java/com/evolveum/midpoint/common/refinery/TestRefinedSchema.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/AbstractResourceObjectDefinitionImpl.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/CompositeObjectDefinition.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/CompositeObjectDefinitionImpl.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceObjectClassDefinitionImpl.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceObjectDefinition.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceObjectTypeDefinition.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceObjectTypeDefinitionImpl.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceSchema.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceSchemaFactory.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/ResourceSchemaImpl.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/deleg/ResourceObjectDefinitionDelegator.java
    M infra/schema/src/main/java/com/evolveum/midpoint/schema/processor/deleg/ResourceObjectTypeDefinitionDelegator.java
    M model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/controller/ModelInteractionServiceImpl.java

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/master' into feature/sqale-closure-update


  Commit: 1cf0a5d3f672d155cba2c8a6f301c1a448faa23b
      https://github.com/Evolveum/midpoint/commit/1cf0a5d3f672d155cba2c8a6f301c1a448faa23b
  Author: Tony Tkáčik <tonydamage at gmail.com>
  Date:   2023-10-02 (Mon, 02 Oct 2023)

  Changed paths:
    M config/sql/native/postgres-upgrade.sql
    M config/sql/native/postgres.sql
    M repo/repo-sqale/src/main/java/com/evolveum/midpoint/repo/sqale/SqaleUtils.java

  Log Message:
  -----------
  Merge remote-tracking branch 'origin/feature/sqale-closure-update'


Compare: https://github.com/Evolveum/midpoint/compare/0d04ef184529...1cf0a5d3f672


More information about the midPoint-svn mailing list